-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mas i1121 reip3 #1838
Merged
Merged
Mas i1121 reip3 #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow for reip without loading the riak_core application
And return 'ok' to make clear the op was successful
+1 |
martinsumner
added a commit
that referenced
this pull request
Dec 19, 2022
* Add reip/3 To allow for reip without loading the riak_core application * Use alternate name * Update riak_kv_console.erl * Update riak_kv_console.erl * reip_manual inputs are atoms * Add warning to update riak.conf file after reip * Make clear where attention is required And return 'ok' to make clear the op was successful * Update rebar.config
martinsumner
added a commit
that referenced
this pull request
Dec 19, 2022
* Do not crash when object's contents is an empty list (#1837) * Add test to illustrate issue * Do not crash when object's contents is an empty list * add missing function clause repair_keys_range in convert_fold (#1839) * add missing function clause repair_keys_range in convert_fold, to unbreak aae_fold for that case * thread converted aae_fold query in riak_client, to complete prev commit * Change the default PR value from 0 to default (#1836) This means that get requests will use bucket-type level Primary Read settings Co-authored-by: Peter Tihanyi <[email protected]> * Mas i1121 reip3 (#1838) * Add reip/3 To allow for reip without loading the riak_core application * Use alternate name * Update riak_kv_console.erl * Update riak_kv_console.erl * reip_manual inputs are atoms * Add warning to update riak.conf file after reip * Make clear where attention is required And return 'ok' to make clear the op was successful * Update rebar.config * Update log (#1840) Make situation clearer in log Rather than change behaviour, just make it clear that the warning can be ignored when shutting down. This should avoid unnecessary concern. * Update Readme, remove mercurial refs Co-authored-by: Enrique Fernández <[email protected]> Co-authored-by: Andrei Zavada <[email protected]> Co-authored-by: Peter Tihanyi <[email protected]> Co-authored-by: Peter Tihanyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
reip_manual/1
function to riak_kv_console that allows reip to be done with knowledge of ring_sir and cluster name - avoiding the need to load riak_core.basho/riak_core#992
basho/riak#1121